netdev - Re: [PATCH] Reduce locking in TX path of forcedth driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:  <20071221185435.2884f118@deepthought>
Date:	Fri, 21 Dec 2007 18:54:35 -0800
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	netdev@...r.kernel.org
Subject:  Re: [PATCH] Reduce locking in TX path of forcedth driver

On Fri, 21 Dec 2007 17:41:34 -0800 (PST)
therbert@...gle.com (Tom Herbert) wrote:

> Reduce the amount of locking in the TX path.  Instead of using both netif_tx_lock and dev->priv->lock on transmitting, a single private lock (dev->priv->tx_lock) is used.  This method is similar to that of the e1000 driver, including the logic to stop the queue in the start xmit functions, and the logic to wake the queue in the TX done functions.  We see some performance improvement with this patch.
> 
> Signed-off-by: Tom Herbert <therbert@...gle.com>


>  
> +	spin_lock_init(&np->tx_lock);
> +
> +	dev->features |= NETIF_F_LLTX;
> +

NAK - lockless transmit is not desirable for real devices.

use netif_tx_lock() instead of your private lock

-- 
Stephen Hemminger <stephen.hemminger@...tta.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html