netdev - Re: [PATCH 3/8] [PATCH] Use 1KB buffer in rndis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071223005111.E699A230E0A@adsl-69-226-248-13.dsl.pltn13.pacbell.net>
Date:	Sat, 22 Dec 2007 16:51:11 -0800
From:	David Brownell <david-b@...bell.net>
To:	bjd@...z.net
Cc:	netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
	jussi.kivilinna@...et.fi
Subject: Re: [PATCH 3/8] [PATCH] Use 1KB buffer in rndis_unbind

> From bjd@...z.net  Sat Dec 22 13:53:03 2007
> From: Bjorge Dijkstra <bjd@...z.net>
> To: dbrownell@...rs.sourceforge.net
> Cc: netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
> 	Jussi Kivilinna <jussi.kivilinna@...et.fi>
> Subject: [PATCH 3/8] [PATCH] Use 1KB buffer in rndis_unbind
> Date: Sat, 22 Dec 2007 22:51:29 +0100
>
> From: Jussi Kivilinna <jussi.kivilinna@...et.fi>
>
> rndis_command requires the caller to pass in a buffer of at least 1KB.
>
> Signed-off-by: Jussi Kivilinna <jussi.kivilinna@...et.fi>
> Signed-off-by: Bjorge Dijkstra <bjd@...z.net>

Acked-by: David Brownell <dbrownell@...rs.sourceforge.net>

> ---
>  drivers/net/usb/rndis_host.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/usb/rndis_host.c b/drivers/net/usb/rndis_host.c
> index 96ef6a9..42b161c 100644
> --- a/drivers/net/usb/rndis_host.c
> +++ b/drivers/net/usb/rndis_host.c
> @@ -577,7 +577,7 @@ static void rndis_unbind(struct usbnet *dev, struct usb_interface *intf)
>  	struct rndis_halt	*halt;
>  
>  	/* try to clear any rndis state/activity (no i/o from stack!) */
> -	halt = kzalloc(sizeof *halt, GFP_KERNEL);
> +	halt = kzalloc(CONTROL_BUFFER_SIZE, GFP_KERNEL);
>  	if (halt) {
>  		halt->msg_type = RNDIS_MSG_HALT;
>  		halt->msg_len = ccpu2(sizeof *halt);
> -- 
> 1.5.2.5
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html