netdev - Re: [RFC] potential bugs in nexten

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0712241653540.6128@dut46.unminc.com>
Date:	Mon, 24 Dec 2007 17:04:39 -0800 (PST)
From:	Dhananjay Phadke <dhananjay@...xen.com>
To:	Al Viro <viro@....linux.org.uk>
cc:	jgarzik@...ox.com, netdev@...r.kernel.org
Subject: Re: [RFC] potential bugs in nexten

Probably I need to clean up much more junk like that from days before I 
took over. I recently cleaned up a bit of rx and tx code, which is more 
frequently executed.

The last one (byte swapping) is serious and I am gonna take care of that 
in next patch. 

Thanks,
-Dhananjay

On Sun, 23 Dec 2007, Al Viro wrote:

> 
> * what are default: doing in netxen_nic_hw_write_wx()/netxen_nic_hw_read_wx()?
> Unlike all other cases they do iomem->iomem copying and AFAICS they are never
> actually triggered.
> 
> * netxen_nic_flash_print() reads the entire user_info from card *in* *host-endian*,
> then uses user_info.serial_number[].
> 	a) do we need to read the rest?
> 	b) more interesting question, don't we need cpu_to_le32() here?  After
> all, that sucker is an array of char, so we want it in the same order regardless
> of the host...
> 
> * in netxen_nic_xmit_frame() we do
> 	hw->cmd_desc_head[saved_producer].flags_opcode =
> 		cpu_to_le16(hw->cmd_desc_head[saved_producer].flags_opcode);
> 	hw->cmd_desc_head[saved_producer].num_of_buffers_total_length =
> 	  cpu_to_le32(hw->cmd_desc_head[saved_producer].
> 			  num_of_buffers_total_length);
> Huh?  Everything that modifies either of those does so in little-endian already.
> This code appeared in commit 6c80b18df3537d1221ab34555c150bccbfd90260 (NetXen:
> Port swap feature for multi port cards); what's going on there?
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html