netdev - Re: : Emit event stream compat iw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071227181439.6F59.40F06B3A@sm.sony.co.jp>
Date:	Thu, 27 Dec 2007 18:24:40 +0900
From:	Masakazu Mokuno <mokuno@...sony.co.jp>
To:	David Miller <davem@...emloft.net>
Cc:	linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: : Emit event stream compat iw_point objects correctly.


On Thu, 27 Dec 2007 00:57:25 -0800 (PST)
David Miller <davem@...emloft.net> wrote:

> From: Masakazu Mokuno <mokuno@...sony.co.jp>
> Date: Thu, 27 Dec 2007 17:51:49 +0900
> 
> > 	Hi
> > 
> > On Fri, 21 Dec 2007 20:58:08 -0800 (PST)
> > David Miller <davem@...emloft.net> wrote:
> > 
> > > @@ -520,7 +530,7 @@ iwe_stream_add_point(char *	stream,		/* Stream of events */
> > >  		memcpy(stream + IW_EV_LCP_LEN,
> > >  		       ((char *) iwe) + IW_EV_LCP_LEN + IW_EV_POINT_OFF,
> > >  		       IW_EV_POINT_PK_LEN - IW_EV_LCP_PK_LEN);
> > 
> > As the alignment of 64bit platforms may be defferent from 32bit one,
> > should it be like the following?
> 
> IW_EV_LCP_LEN is the same on both 32-bit and 64-bit platforms, it is
> just the size of the "len" and "cmd" portions of struct iw_event.
> 

IW_EV_LCP_PK_LEN ?

#define IW_EV_LCP_PK_LEN        (4)

> Those are both __u16, so IW_EV_LCP_LEN always evaluates to "4",
> try it if you do not believe me. :-)

Although I believed you, I tried :)

On ppc64 (PS3), IW_EV_LCP_LEN is 8, not 4.

include/linux/wireless.h:

#define IW_EV_LCP_LEN   (sizeof(struct iw_event) - sizeof(union iwreq_data))

where sizeof(struct iw_event) == 24, sizeof(union iwreq_data) == 16 on
PS3.

-- 
Masakazu MOKUNO

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html