netdev - Re: [PATCH] Add Linksys WCF11 to hostap driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1198901689.2221.3.camel@dv>
Date:	Fri, 28 Dec 2007 23:14:49 -0500
From:	Pavel Roskin <proski@....org>
To:	Marcin Juszkiewicz <openembedded@...rwu.biz>
Cc:	linux-wireless@...r.kernel.org, Jouni Malinen <j@...fi>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] Add Linksys WCF11 to hostap driver

Hello!

On Fri, 2007-12-28 at 14:16 +0100, Marcin Juszkiewicz wrote:

> +       PCMCIA_DEVICE_PROD_ID1234(
> +               "The Linksys Group, Inc.", "Wireless Network CF Card", "ISL37300P",
> +               "RevA",
> +               0xa5f472c2, 0x9c05598d, 0xc9049a39, 0x57a66194),

I would prefer that revisions are not used for card identification in
presence of the chip name.  It's not like RevB would need another driver
as long as "ISL37300P" is still a part of the PCMCIA ID.
PCMCIA_DEVICE_PROD_ID123 should be enough.

-- 
Regards,
Pavel Roskin
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html