netdev - Re: [PATCH] Make FC, FDDI, HIPPI and TR tristate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20071229.001953.136541622.davem@davemloft.net>
Date:	Sat, 29 Dec 2007 00:19:53 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jengelh@...putergmbh.de
Cc:	bunk@...nel.org, jgarzik@...ox.com, netdev@...r.kernel.org
Subject: Re: [PATCH] Make FC, FDDI, HIPPI and TR tristate

From: Jan Engelhardt <jengelh@...putergmbh.de>
Date: Sat, 29 Dec 2007 01:41:23 +0100 (CET)

> 
> On Dec 29 2007 02:09, Adrian Bunk wrote:
> >On Sat, Dec 29, 2007 at 12:45:12AM +0100, Jan Engelhardt wrote:
> >> Turn CONFIG_FC, CONFIG_FDDI, CONFIG_HIPPI and CONFIG_TR into tristate
> >> so they can be built as modules. This will allow CONFIG_LLC to be
> >> built as a module too, overall reducing the core kernel image size.
> >>...
> >
> >Just an example of code you have to fix if you do this:
> >
> >$ grep -r "#ifdef CONFIG_TR" net/
> 
> Ah, thank you for reminding me. For lec.c, would it be ok to do
> 
> #if defined(CONFIG_TR) || defined(CONFIG_TR_MODULE)
> #	define WITH_TR 1
> #endif

We don't have a WITH_IPV6, we open code the ifdef check
all over the tree.

For consistency you should do that here too.  Please don't
add new ad-hoc macros to deal with situations like this.
If it's really a problem it should be handled globally in
the confines of the config system, not on a case-by-case
basis.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html