netdev - Re: [PATCH 2/4] [CORE]: adding memory accounting points

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47793A78.3050100@redhat.com>
Date:	Mon, 31 Dec 2007 13:52:40 -0500
From:	Hideo AOKI <haoki@...hat.com>
To:	David Miller <davem@...emloft.net>
CC:	herbert@...dor.apana.org.au, vladislav.yasevich@...com,
	netdev@...r.kernel.org, lksctp-developers@...ts.sourceforge.net,
	tyasui@...hat.com, mhiramat@...hat.com,
	satoshi.oshima.fk@...achi.com, billfink@...dspring.com,
	andi@...stfloor.org, johnpol@....mipt.ru,
	shemminger@...ux-foundation.org, yoshfuji@...ux-ipv6.org,
	yumiko.sugita.yf@...achi.com, haoki@...hat.com
Subject: Re: [PATCH 2/4] [CORE]: adding memory accounting points

David Miller wrote:

> This patch would not apply, because is contained changes
> present in the first patch, specifically:
<snip>
> And now I see exactly what you did, and it is quite careless.
> 
> You wrote one big patch then tried to split it up by hand.  This
> proves to me that you did not test the patches individually.  Even
> worse, you did not even try to apply each patch nor compile the tree
> each step along the way as a basic sanity check.

Hello David,

You are right. Since I felt the patch was big, I divided
into three for review. And I mistook during the dividing.

> This wastes a lot of my time, as well as the time of other developers
> who might want to try out and test your changes.

I apologize for wasting your time.


> I will fix it up this time, but please do not ever do this again.

I really appreciate the fix. And I understood this.

Best regards,
Hideo

-- 
Hitachi Computer Products (America) Inc.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html