netdev - Re: [PATCH 25/26] atl1: add NAPI support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 31 Dec 2007 21:58:17 -0800
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	Jay Cliburn <jacliburn@...lsouth.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 25/26] atl1: add NAPI support

On Mon, 31 Dec 2007 20:22:52 -0600
Jay Cliburn <jacliburn@...lsouth.net> wrote:

> Add support for NAPI, styled after the e1000 NAPI implementation.  That we
> follow the e1000 for NAPI shouldn't come as much of a surprise, since the
> entire atl1 driver is based heavily upon it.
> 
> Signed-off-by: Jay Cliburn <jacliburn@...lsouth.net>
> ---
>  drivers/net/Kconfig     |   14 ++++
>  drivers/net/atlx/atl1.c |  151 +++++++++++++++++++++++++++++++++++++++++++++--
>  drivers/net/atlx/atl1.h |   20 ++++++
>  drivers/net/atlx/atlx.h |    7 ++-
>  4 files changed, 186 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index d9107e5..095629f 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2371,6 +2371,20 @@ config ATL1
>  	  To compile this driver as a module, choose M here.  The module
>  	  will be called atl1.
>  
> +config ATL1_NAPI
> +	bool "Use Rx Polling (NAPI) (EXPERIMENTAL)"
> +	depends on ATL1 && EXPERIMENTAL
> +	help
> +	  NAPI is a new driver API designed to reduce CPU and interrupt load
> +	  when the driver is receiving lots of packets from the card. It is
> +	  still somewhat experimental and thus not yet enabled by default.
> +
> +	  If your estimated Rx load is 10kpps or more, or if the card will be
> +	  deployed on potentially unfriendly networks (e.g. in a firewall),
> +	  then say Y here.
> +
> +	  If in doubt, say N.
> +
>  endif # NETDEV_1000
>  
>  #
> diff --git a/drivers/net/atlx/atl1.c b/drivers/net/atlx/atl1.c
> index 237622e..10bccf6 100644
> --- a/drivers/net/atlx/atl1.c
> +++ b/drivers/net/atlx/atl1.c
> @@ -756,7 +756,16 @@ static void atl1_set_mac_addr(struct atl1_hw *hw)
>  
>  static int atl1_alloc_queues(struct atl1_adapter *adapter)
>  {
> -	/* temporary placeholder function for NAPI */
> +#ifdef CONFIG_ATL1_NAPI
> +	int size;
> +
> +	size = sizeof(struct net_device) * adapter->num_rx_queues;
> +	adapter->polling_netdev = kmalloc(size, GFP_KERNEL);
> +	if (!adapter->polling_netdev)
> +		return -ENOMEM;
> +
> +	memset(adapter->polling_netdev, 0, size);
> +#endif

You don't need to allocate pseudo-devices anymore in 2.6.24 or later.
rework to just use napi structures.



-- 
Stephen Hemminger <stephen.hemminger@...tta.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html