netdev - Re: [IPSEC] flow : Remove an unecessary ____cacheline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 01 Jan 2008 19:24:39 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dada1@...mosbay.com
Cc:	netdev@...r.kernel.org
Subject: Re: [IPSEC] flow : Remove an unecessary ____cacheline_aligned

From: Eric Dumazet <dada1@...mosbay.com>
Date: Tue, 01 Jan 2008 16:33:33 +0100

> We use a percpu variable named flow_hash_info, which holds 12 bytes.
> 
> It is currently marked as ____cacheline_aligned, which makes linker
> skip space to properly align this variable.
> 
> Before :
> c065cc90 D per_cpu__softnet_data
> c065cd00 d per_cpu__flow_tables
> <Here, hole of 124 bytes>
> c065cd80 d per_cpu__flow_hash_info
> <Here, hole of 116 bytes>
> c065ce00 d per_cpu__flow_flush_tasklets
> c065ce14 d per_cpu__rt_cache_stat
> 
> 
> This alignement is quite unproductive, and removing it reduces the
> size of percpu data (by 240 bytes on my x86 machine), and improves
> performance (flow_tables & flow_hash_info can share a single cache
> line)
> 
> After patch :
> c065cc04 D per_cpu__softnet_data
> c065cc4c d per_cpu__flow_tables
> c065cc50 d per_cpu__flow_hash_info
> c065cc5c d per_cpu__flow_flush_tasklets
> c065cc70 d per_cpu__rt_cache_stat
> 
> Signed-off-by: Eric Dumazet <dada1@...mosbay.com>

Also applied, thanks a lot for these patches Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html