netdev - RE: [PATCH 2.6.23.12] net/bonding: option to specify initial bond interface number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <413FEEF1743111439393FB76D0221E4809790A38@leopard.zoo.q9networks.com>
Date:	Thu, 3 Jan 2008 10:26:12 -0500
From:	"Jari Takkala" <Jari.Takkala@...com>
To:	"Randy Dunlap" <randy.dunlap@...cle.com>
Cc:	<netdev@...r.kernel.org>
Subject: RE: [PATCH 2.6.23.12] net/bonding: option to specify initial bond interface number

On Wednesday, January 02, 2008 16:56, Randy Dunlap wrote:
> You could (should) make <ifnum> be unsigned int and then use
> module_param(ifnum, uint, 0); and then ...
> 
> then this block is mostly useless since ifnum cannot be < 0.
> And how could it ever be > INT_MAX (when ifnum was an int)?
> 
> If <ifnum> is unsigned int but you want to limit it to INT_MAX,
> then half of this if-test would be OK.
> 

Thanks, that makes sense. I simply copied some of the max_bonds code which uses a signed int. I suppose that could be changed as well. I will post back a new patch.

Jari
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html