netdev - Re: [XFRM]: Do not define km_migrate() if !CONFIG_XFRM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080103.204343.134131840.davem@davemloft.net>
Date:	Thu, 03 Jan 2008 20:43:43 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dada1@...mosbay.com
Cc:	netdev@...r.kernel.org
Subject: Re: [XFRM]: Do not define km_migrate() if !CONFIG_XFRM_MIGRATE

From: Eric Dumazet <dada1@...mosbay.com>
Date: Thu, 3 Jan 2008 18:24:49 +0100

> In include/net/xfrm.h we find :
> 
> #ifdef CONFIG_XFRM_MIGRATE
> extern int km_migrate(struct xfrm_selector *sel, u8 dir, u8 type,
>                       struct xfrm_migrate *m, int num_bundles);
> ...
> #endif
> 
> We can also guard the function body itself in net/xfrm/xfrm_state.c
> with same condition.
> 
> (Problem spoted by sparse checker)
> make C=2 net/xfrm/xfrm_state.o
> ...
> net/xfrm/xfrm_state.c:1765:5: warning: symbol 'km_migrate' was not declared. Should it be static?
> ...
> 
> Signed-off-by: Eric Dumazet <dada1@...mosbay.com>

Applied to net-2.6, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html