netdev - Re: [ICMP]: Avoid sparse warnings in net/ipv4/icmp.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080103.212610.263261100.davem@davemloft.net>
Date:	Thu, 03 Jan 2008 21:26:10 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dada1@...mosbay.com
Cc:	netdev@...r.kernel.org
Subject: Re: [ICMP]: Avoid sparse warnings in net/ipv4/icmp.c

From: Eric Dumazet <dada1@...mosbay.com>
Date: Fri, 04 Jan 2008 06:24:20 +0100

>    CHECK   net/ipv4/icmp.c
> net/ipv4/icmp.c:249:13: warning: context imbalance in 'icmp_xmit_unlock' - 
> unexpected unlock
> net/ipv4/icmp.c:376:13: warning: context imbalance in 'icmp_reply' - different 
> lock contexts for basic block
> net/ipv4/icmp.c:430:6: warning: context imbalance in 'icmp_send' - different 
> lock contexts for basic block
> 
> Solution is to declare icmp_xmit_unlock() as __inline__ (similar with 
> icmp_xmit_lock())

Please use "inline" instead of "__inline__".  If other stuff
uses __inline__ in that file, feel free to fix it up too.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html