netdev - Re: [PATCH] [INET] Fix netdev renaming and inet address labels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080104.005704.267427157.davem@davemloft.net>
Date:	Fri, 04 Jan 2008 00:57:04 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	markmc@...hat.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] [INET] Fix netdev renaming and inet address labels

From: Mark McLoughlin <markmc@...hat.com>
Date: Thu,  3 Jan 2008 15:57:03 +0000

> When re-naming an interface, the previous secondary address
> labels get lost e.g.
> 
>   $> brctl addbr foo
>   $> ip addr add 192.168.0.1 dev foo
>   $> ip addr add 192.168.0.2 dev foo label foo:00
>   $> ip addr show dev foo | grep inet
>     inet 192.168.0.1/32 scope global foo
>     inet 192.168.0.2/32 scope global foo:00
>   $> ip link set foo name bar
>   $> ip addr show dev bar | grep inet
>     inet 192.168.0.1/32 scope global bar
>     inet 192.168.0.2/32 scope global bar:2
> 
> Turns out to be a simple thinko in inetdev_changename() - clearly we
> want to look at the address label, rather than the device name, for
> a suffix to retain.
> 
> Signed-off-by: Mark McLoughlin <markmc@...hat.com>

This bug has been there since the function in question was
written :-)

Patch applied, thanks Mark.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html