netdev - Re: sparc oops in ip_fast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080106041430.GA3784@gondor.apana.org.au>
Date:	Sun, 6 Jan 2008 15:14:30 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	m.kozlowski@...land.pl, davem@...emloft.net,
	sparclinux@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, Patrick McHardy <kaber@...sh.net>
Subject: Re: sparc oops in ip_fast_csum

On Sun, Jan 06, 2008 at 02:02:14AM +0000, Al Viro wrote:
> 
> E.g. what about ipt_REJECT.c::send_reset()?  Or myri10ge_get_frag_header()?

Yes both look wrong.

Patrick, please have a look at the former.  In fact it's not just
that ihl may be bogus (which might be harmless as long as the REJECT
hook only gets called from within the IP stack), I think REJECT would
also do the wrong thing if the packet had IP options.  So perhaps we
should just make it create a packet from scratch rather than being
too clever in reusing the old one.

As to LRO, I must say it was a pretty shoddy job.  Now I can't complain
too much because I wasn't able to spend any time in 2007 working on it.
But it's definitely high on my todo list for 2008.

Oh and Al, your effort in going through all the ip_fast_csum callers
is much appreciated!

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html