[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20080107.211018.160153013.davem@davemloft.net>
Date: Mon, 07 Jan 2008 21:10:18 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: andi@...stfloor.org
Cc: herbert@...dor.apana.org.au, ilpo.jarvinen@...sinki.fi,
netdev@...r.kernel.org, acme@...hat.com, paul.moore@...com,
latten@...ibm.com
Subject: Re: [PATCH 3/4] [XFRM]: Kill some bloat
From: Andi Kleen <andi@...stfloor.org>
Date: Tue, 8 Jan 2008 06:00:07 +0100
> On Mon, Jan 07, 2008 at 07:37:00PM -0800, David Miller wrote:
> > The vast majority of them are one, two, and three liners.
>
> % awk ' { line++ } ; /^{/ { total++; start = line } ; /^}/ { len=line-start-3; if (len > 4) l++; if (len >= 10) k++; } ; END { print total, l, l/total, k, k/total }' < include/net/tcp.h
> 68 28 0.411765 20 0.294118
>
> 41% are over 4 lines, 29% are >= 10 lines.
Take out the comments and whitespace lines, your script is
too simplistic.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists