netdev - Re: [RFC PATCH v2 1/2] NET: Clone the sk_buff 'iif' field in __skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080107.214846.40512910.davem@davemloft.net>
Date:	Mon, 07 Jan 2008 21:48:46 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jmorris@...ei.org
Cc:	paul.moore@...com, netdev@...r.kernel.org
Subject: Re: [RFC PATCH v2 1/2] NET: Clone the sk_buff 'iif' field in
 __skb_clone()

From: James Morris <jmorris@...ei.org>
Date: Tue, 8 Jan 2008 08:11:11 +1100 (EST)

> On Mon, 7 Jan 2008, Paul Moore wrote:
> 
> > Both NetLabel and SELinux (other LSMs may grow to use it as well) rely on the
> > 'iif' field to determine the receiving network interface of inbound packets.
> > Unfortunately, at present this field is not preserved across a skb clone
> > operation which can lead to garbage values if the cloned skb is sent back
> > through the network stack.  This patch corrects this problem by properly
> > copying the 'iif' field in __skb_clone() and removing the 'iif' field
> > assignment from skb_act_clone() since it is no longer needed.
> > 
> > Also, while we are here, put the assignments in the same order as the offsets
> > to reduce cacheline bounces.
> > 
> > Signed-off-by: Paul Moore <paul.moore@...com>
> 
> Dave, perhaps this one should pushed to Linus now as a bugfix?

Probably we should, yes.

Ok, that's what I'll do.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html