netdev - Re: [XFRM]: xfrm_state_clone() should be static, not exported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080108.013613.179218949.davem@davemloft.net>
Date:	Tue, 08 Jan 2008 01:36:13 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dada1@...mosbay.com
Cc:	netdev@...r.kernel.org
Subject: Re: [XFRM]: xfrm_state_clone() should be static, not exported

From: Eric Dumazet <dada1@...mosbay.com>
Date: Tue, 08 Jan 2008 09:00:20 +0100

> xfrm_state_clone() is not used outside of net/xfrm/xfrm_state.c
> There is no need to export it.
> 
> Spoted by sparse checker.
>    CHECK   net/xfrm/xfrm_state.c
> net/xfrm/xfrm_state.c:1103:19: warning: symbol 'xfrm_state_clone' was not 
> declared. Should it be static?
> 
> Signed-off-by: Eric Dumazet <dada1@...mosbay.com>

Applied to net-2.6.25, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html