netdev - Re: [PATCH 0/3] bonding: 3 fixes for 2.6.24

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1JCU76-00077z-00@gondolin.me.apana.org.au>
Date:	Wed, 09 Jan 2008 17:08:32 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	andy@...yhouse.net (Andy Gospodarek)
Cc:	olel@....pl, fubar@...ibm.com, netdev@...r.kernel.org,
	jgarzik@...ox.com, davem@...emloft.net, andy@...yhouse.net
Subject: Re: [PATCH 0/3] bonding: 3 fixes for 2.6.24

Andy Gospodarek <andy@...yhouse.net> wrote:
> 
> Jay's patches will not fix this issue.  I think something like this did
> it for me, but as I mentioned to Jay in the last thread, I'm not
> convinced it doesn't violate some of the locking expectations we have.
> 
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index 423298c..3c6619a 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -3915,7 +3915,7 @@ static void bond_set_multicast_list(struct net_device *bond_dev)
>        struct bonding *bond = bond_dev->priv;
>        struct dev_mc_list *dmi;
> 
> -       write_lock_bh(&bond->lock);
> +       read_lock(&bond->lock);

This is wrong.  As I said before, the correct fix (until set_multicast
no longer gets called from BH context) is to change all you process
context read_lock's to read_lock_bh.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html