netdev - Re: [XFRM]: xfrm_algo_clone() allocates too much memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <478477C7.9030004@cosmosbay.com>
Date:	Wed, 09 Jan 2008 08:29:11 +0100
From:	Eric Dumazet <dada1@...mosbay.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
CC:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [XFRM]: xfrm_algo_clone() allocates too much memory

Herbert Xu a écrit :
> Eric Dumazet <dada1@...mosbay.com> wrote:
>> diff --git a/include/net/xfrm.h b/include/net/xfrm.h
>> index 58dfa82..731f0a8 100644
>> --- a/include/net/xfrm.h
>> +++ b/include/net/xfrm.h
>> @@ -1188,10 +1188,15 @@ static inline int xfrm_aevent_is_on(void)
>>        return ret;
>> }
>>
>> +static inline int alg_len(struct xfrm_algo *alg)
> 
> Could you please add an xfrm prefix to this?

Sure, thanks for the suggestion :)

[XFRM]: xfrm_algo_clone() allocates too much memory

alg_key_len is the length in bits of the key, not in bytes.

Best way to fix this is to move alg_len() function from net/xfrm/xfrm_user.c 
to include/net/xfrm.h, and to use it in xfrm_algo_clone()

alg_len() is renamed to xfrm_alg_len() because of its global exposition.

Signed-off-by: Eric Dumazet <dada1@...mosbay.com>
Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

  include/net/xfrm.h   |    7 ++++++-
  net/xfrm/xfrm_user.c |   17 ++++++-----------
  2 files changed, 12 insertions(+), 12 deletions(-)

View attachment "xfrm_algo_clone.patch" of type "text/plain" (2472 bytes)