netdev - Re: [klibc] [patch] import socket defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080110.224749.66236050.davem@davemloft.net>
Date:	Thu, 10 Jan 2008 22:47:49 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	vapier@...too.org
Cc:	hpa@...or.com, netdev@...r.kernel.org, klibc@...or.com
Subject: Re: [klibc] [patch] import socket defines

From: Mike Frysinger <vapier@...too.org>
Date: Fri, 11 Jan 2008 01:23:37 -0500

> On Friday 11 January 2008, David Miller wrote:
> > From: "H. Peter Anvin" <hpa@...or.com>
> > > Seems the most logical thing to do would be to break out the small
> > > portion that everyone wants into <linux/sockaddr.h> or somesuch, and
> > > then remove those ifdefs entirely.
> > >
> > > Proposed patch (still being tested) attached...
> >
> > I think this would clearly break existing glibc builds.
> >
> > I agree with fixing the ifdef checks, but not like this.
> 
> how ?  the large crap in linux/socket.h never made it into glibc builds, and 
> the few things at the top which were relocated to linux/sockaddr.h are still 
> pulled in via linux/socket.h.  for glibc, the resulting '#include 
> <linux/socket.h>' should be unchanged.

Hmmm...

Doesn't glibc include linux/socket.h?  If so, before it wouldn't get
the sa_family_t et al. defines (because __GLIBC__ will be defined and
it will be >= 2), but with your change it get those things.

Correct me if I'm wrong.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html