netdev - Re: [klibc] [patch] import socket defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4787221F.3030201@zytor.com>
Date:	Fri, 11 Jan 2008 00:00:31 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Mike Frysinger <vapier@...too.org>
CC:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	klibc@...or.com
Subject: Re: [klibc] [patch] import socket defines

Mike Frysinger wrote:
>> all this stuff is ABI constants, and the only reason glibc 
>> doesn't use them is that glibc prefers to use enums over #defines.
> 
> a proper libc defines things in their headers according to the POSIX specs 
> rather than relying on others to do it for them.  if you want to argue about 
> linux-specific ABI pieces being exported, then you probably have a valid 
> point, but socket.h is hardly that.

Have you looked at it?!!?  It's full of ABI constants, and that's what I 
care about.  POSIX doesn't define, say, AF_UNIX; that's an ABI specific.

> so if the only consumer is klibc and you're against adding these things to it, 
> special case it for __KLIBC__.

No, let's split the header so that there are *no* libc knowledge in the 
kernel.  For the kernel to have knowledge about the specifics of any 
particular libc (klibc, glibc, or any other) is stupid, and that's the 
whole reason we're in this spot to begin with.

Again, I don't particularly care about what they're named, but the whole 
point is

	#include <linux/foo.h>

if you want the subset and

	#include <linux/bar.h>

if you want the whole set.

No libc specifics, and no feature test macros, which I think we can both 
agree are uglier than hell.

I thought the naming worked out nicer with <linux/sockaddr.h>, but I 
*don't really care*.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html