netdev - Re: RFC: igb: Intel 82575 gigabit ethernet driver (take #3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080111091728.GB14910@infradead.org>
Date:	Fri, 11 Jan 2008 09:17:28 +0000
From:	Christoph Hellwig <hch@...radead.org>
To:	"Kok, Auke" <auke-jan.h.kok@...el.com>
Cc:	NetDev <netdev@...r.kernel.org>, Jeff Garzik <jgarzik@...ox.com>,
	Arjan van de Ven <arjan@...ux.intel.com>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	"Ronciak, John" <john.ronciak@...el.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: RFC: igb: Intel 82575 gigabit ethernet driver (take #3)

On Thu, Jan 10, 2008 at 03:32:28PM -0800, Kok, Auke wrote:
> - cleaned up largely against sparse, checkpatch

largely means not completely, right?  Please make sure there's no sparse
warnings left at least.  checkpatch is not that criticial, but it would
be good to have an explanation for everything left.


some comments on the patch

 - please remove that sill copyright heder on the Makefile, it's hard
   to claim any rights on a trivial 3 line makefile.
 - also please use igb-y instead of igb-objs in the Makefile
 - the driver would be a lot more readable (and more importantly
   hackable) if it was written in a natural flow instead of having dozends 
   of lines of forward declarations in every file.
 - so you're adding your own phy abstraction.  Is there a good reason
   you can't simply use the generic phylib?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html