netdev - Re: [PATCH] Documentation: add a guideline for hard_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47893EC0.1080303@pobox.com>
Date:	Sat, 12 Jan 2008 17:27:12 -0500
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Matti Linnanvuori <mattilinnanvuori@...oo.com>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH] Documentation: add a guideline for hard_start_xmit method
 not to modify SKB

Matti Linnanvuori wrote:
> From: Matti Linnanvuori <mattilinnanvuori@...oo.com>
> 
> Add a guideline for hard_start_xmit method not to
> modify SKB.
> 
> Signed-off-by: Matti Linnanvuori
> <mattilinnanvuori@...oo.com>
> 
> ---
> 
> 
> --- a/Documentation/networking/driver.txt	2007-12-22
> 18:50:28.062169500 +0200
> +++ b/Documentation/networking/driver.txt	2007-12-22
> 19:10:58.726566000 +0200
> 
> @@ -74,6 +74,9 @@ Transmit path guidelines:
>     If you return 1 from the hard_start_xmit method,
> you must not keep
>     any reference to that SKB and you must not attempt
> to free it up.
>  
> +4) A hard_start_xmit method must not modify the
> cloned parts of the
> +   SKB.
> +
>  Probing guidelines:
>  
>  1) Any hardware layer address you obtain for your
> device should
> 

patch is word-wrapped


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html