[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20080112.032318.201654370.davem@davemloft.net>
Date: Sat, 12 Jan 2008 03:23:18 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: ilpo.jarvinen@...sinki.fi
Cc: netdev@...r.kernel.org, kaber@...sh.net,
netfilter-devel@...r.kernel.org
Subject: Re: [PATCH 6/8] [NETFILTER] xt_policy.c: kill some bloat
From: "Ilpo_Järvinen" <ilpo.jarvinen@...sinki.fi>
Date: Sat, 12 Jan 2008 11:34:27 +0200
Ilpo, please post netfilter patches to netfilter-devel,
CC:'ing Patrick McHardy.
Patrick, please review, thanks.
> net/netfilter/xt_policy.c:
> policy_mt | -906
> 1 function changed, 906 bytes removed, diff: -906
>
> net/netfilter/xt_policy.c:
> match_xfrm_state | +427
> 1 function changed, 427 bytes added, diff: +427
>
> net/netfilter/xt_policy.o:
> 2 functions changed, 427 bytes added, 906 bytes removed, diff: -479
>
> Alternatively, this could be done by combining identical
> parts of the match_policy_in/out()
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>
> ---
> net/netfilter/xt_policy.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/netfilter/xt_policy.c b/net/netfilter/xt_policy.c
> index 46ee7e8..45731ca 100644
> --- a/net/netfilter/xt_policy.c
> +++ b/net/netfilter/xt_policy.c
> @@ -33,7 +33,7 @@ xt_addr_cmp(const union xt_policy_addr *a1, const union xt_policy_addr *m,
> return false;
> }
>
> -static inline bool
> +static bool
> match_xfrm_state(const struct xfrm_state *x, const struct xt_policy_elem *e,
> unsigned short family)
> {
> --
> 1.5.0.6
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists