netdev - Re: [FIB]: full_children & empty_children should be uint, not ushort

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080113.223205.38618230.davem@davemloft.net>
Date:	Sun, 13 Jan 2008 22:32:05 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	Robert.Olsson@...a.slu.se
Cc:	dada1@...mosbay.com, stephen.hemminger@...tta.com,
	robert.olsson@....uu.se, netdev@...r.kernel.org
Subject: Re: [FIB]: full_children & empty_children should be uint, not
 ushort

From: Robert Olsson <Robert.Olsson@...a.slu.se>
Date: Sun, 13 Jan 2008 23:02:11 +0100

> 
> Eric Dumazet writes:
>  > Eric Dumazet a écrit :
>  > > 4) full_children & empty_children being 'unsigned short',
>  > >    we probably are limited to 2^15 elements, but I could not
>  > >    find this limit enforced somewhere.
> 
>  > Two fixes are possible : Enlarge full_children & empty_children to 32bits, or 
>  > force a limit in code to never exceed 2^15 children in a tnode. I chose the 
>  > first solution since it can be done with 0 memory cost on 64bit arches.
 ...
>  Thanks for spotting this. No we don't want put limits on the (root) node size.
>  You see the comment in code is correct so unsigned short are some leftover from 
>  old testing which could have hit us hard as the routing table slowly grows.
 ...
> Signed-off-by: Robert Olsson <robert.olsson@....uu.se>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html