netdev - Re: [patch for 2.6.24? 1/1] bonding: locking fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080114144754.29a448ad.akpm@linux-foundation.org>
Date:	Mon, 14 Jan 2008 14:47:54 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Krzysztof Oledzki <olel@....pl>
Cc:	davem@...emloft.net, jeff@...zik.org,
	shemminger@...ux-foundation.org, Jay Vosburgh <fubar@...ibm.com>,
	netdev@...r.kernel.org
Subject: Re: [patch for 2.6.24? 1/1] bonding: locking fix


(cc's added)

On Mon, 14 Jan 2008 23:14:25 +0100 (CET)
Krzysztof Oledzki <olel@....pl> wrote:

> 
> 
> On Mon, 14 Jan 2008, akpm@...ux-foundation.org wrote:
> 
> > From: Andrew Morton <akpm@...ux-foundation.org>
> >
> > Remove stray rtnl_unlock().
> >
> > Addresses http://bugzilla.kernel.org/show_bug.cgi?id=9542
> >
> > Cc: "David S. Miller" <davem@...emloft.net>
> > Cc: Stephen Hemminger <shemminger@...ux-foundation.org>
> > Cc: Krzysztof Oledzki <olel@....pl>
> > Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> > ---
> >
> > drivers/net/bonding/bond_sysfs.c |    2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff -puN drivers/net/bonding/bond_sysfs.c~bonding-locking-fix drivers/net/bonding/bond_sysfs.c
> > --- a/drivers/net/bonding/bond_sysfs.c~bonding-locking-fix
> > +++ a/drivers/net/bonding/bond_sysfs.c
> > @@ -1111,8 +1111,6 @@ static ssize_t bonding_store_primary(str
> > out:
> > 	write_unlock_bh(&bond->lock);
> >
> > -	rtnl_unlock();
> > -
> > 	return count;
> > }
> > static DEVICE_ATTR(primary, S_IRUGO | S_IWUSR, bonding_show_primary, bonding_store_primary);
> > _
> >
> 
> http://thread.gmane.org/gmane.linux.network/82566/focus=83142
> 

That's bond_lock.

This patch (below) addresses what appears to me to be an obvious
imbalance in rtnl_lock.

I don't care how it's fixed, really.  Someone please fix it?




From: Andrew Morton <akpm@...ux-foundation.org>

Remove stray rtnl_unlock().

Addresses http://bugzilla.kernel.org/show_bug.cgi?id=9542

Cc: "David S. Miller" <davem@...emloft.net>
Cc: Stephen Hemminger <shemminger@...ux-foundation.org>
Cc: Krzysztof Oledzki <olel@....pl>
Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
---

 drivers/net/bonding/bond_sysfs.c |    2 --
 1 file changed, 2 deletions(-)

diff -puN drivers/net/bonding/bond_sysfs.c~bonding-locking-fix drivers/net/bonding/bond_sysfs.c
--- a/drivers/net/bonding/bond_sysfs.c~bonding-locking-fix
+++ a/drivers/net/bonding/bond_sysfs.c
@@ -1111,8 +1111,6 @@ static ssize_t bonding_store_primary(str
 out:
 	write_unlock_bh(&bond->lock);
 
-	rtnl_unlock();
-
 	return count;
 }
 static DEVICE_ATTR(primary, S_IRUGO | S_IWUSR, bonding_show_primary, bonding_store_primary);
_

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html