netdev - Re: [PATCH 1/3] drivers/net/ipg.c: Fix skbuff leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20080114231549.GB29734@electric-eye.fr.zoreil.com>
Date:	Tue, 15 Jan 2008 00:15:49 +0100
From:	Francois Romieu <romieu@...zoreil.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/3] drivers/net/ipg.c: Fix skbuff leak

David Miller <davem@...emloft.net> :
> From: Francois Romieu <romieu@...zoreil.com>
> > 
> > I should be able to test your r8169 NAPI changes tomorrow.
> 
> Thank you.

(sorry for the delay)

I think that the r8169 part should be reverted.

. With it, my 8169 oopsed unexpectedly in rtl8169_reinit_task a few
  seconds after I started a 'ping -q -f -l64 -s 36' and before I did
  anything else. I do not have a clear explanation for the oops yet.

. rtl8169_reset_task will not like it as it could allow two racing
  r8169_rx_interrupt.

. The irq will be enabled later when needed: the modified code is
  only relevant for the reset/reinit tasks.

. After reverting the hunk, the 8168 in the same box stood the same
  stream (> 50kpps in both direction). Everything worked as expected
  when I ifconfiged it down, then up again. Same thing when I pluged
  the cable out then in.

I'll give it more testing/thought.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html