netdev - Re: [X25]: Avoid divides and sparse warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080113.222907.152771528.davem@davemloft.net>
Date:	Sun, 13 Jan 2008 22:29:07 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dada1@...mosbay.com
Cc:	netdev@...r.kernel.org
Subject: Re: [X25]: Avoid divides and sparse warnings

From: Eric Dumazet <dada1@...mosbay.com>
Date: Sun, 13 Jan 2008 11:33:01 +0100

>    CHECK   net/x25/af_x25.c
> net/x25/af_x25.c:117:46: warning: expensive signed divide
>    CHECK   net/x25/x25_facilities.c
> net/x25/x25_facilities.c:209:30: warning: expensive signed divide
>    CHECK   net/x25/x25_in.c
> net/x25/x25_in.c:250:26: warning: expensive signed divide
>    CHECK   net/x25/x25_proc.c
> net/x25/x25_proc.c:48:11: warning: context imbalance in 'x25_seq_route_start' 
> - wrong count at exit
> net/x25/x25_proc.c:72:13: warning: context imbalance in 'x25_seq_route_stop' - 
> unexpected unlock
> net/x25/x25_proc.c:112:11: warning: context imbalance in 
> 'x25_seq_socket_start' - wrong count at exit
> net/x25/x25_proc.c:129:13: warning: context imbalance in 'x25_seq_socket_stop' 
> - unexpected unlock
> net/x25/x25_proc.c:190:11: warning: context imbalance in 
> 'x25_seq_forward_start' - wrong count at exit
> net/x25/x25_proc.c:215:13: warning: context imbalance in 
> 'x25_seq_forward_stop' - unexpected unlock
>    CHECK   net/x25/x25_subr.c
> net/x25/x25_subr.c:362:57: warning: expensive signed divide
> 
> Signed-off-by: Eric Dumazet <dada1@...mosbay.com>

Applied, thanks Eric.

We might just want to make sk_rcvbuf et al. unsigned, it
crops up a lot and I can't see any valid reason for it
to be negative or for uses of it to matter with other
signed values.

Or did we discuss that to death already? :-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html