netdev - Re: [PATCH][v2] phylib: add module owner to the mii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <CFE6E252-4CB9-4F91-ABE6-330798408E50@freescale.com>
Date:	Mon, 14 Jan 2008 12:56:23 -0600
From:	Andy Fleming <afleming@...escale.com>
To:	Ionut Nicu <ionut.nicu@...escale.com>
Cc:	netdev@...r.kernel.org, shemminger@...ux-foundation.org
Subject: Re: [PATCH][v2] phylib: add module owner to the mii_bus structure


On Dec 28, 2007, at 11:31, Ionut Nicu wrote:

> Prevent unloading mii bus driver module when other modules have  
> references to some
> phydevs on that bus. Added a new member (module owner) to struct  
> mii_bus and added
> code to increment the mii bus owner module usage count on  
> phy_connect and decrement
> it on phy_disconnect
>
> Set the module owner in the ucc_geth_mdio driver.
>
> Signed-off-by: Ionut Nicu <ionut.nicu@...escale.com>
> Tested-by: Emil Medve <Emilian.Medve@...escale.com>
> ---
>  drivers/net/phy/phy_device.c |    9 ++++++++-
>  drivers/net/ucc_geth_mii.c   |    3 +++


> diff --git a/drivers/net/ucc_geth_mii.c b/drivers/net/ucc_geth_mii.c
> index a3af4ea..84c7295 100644
> --- a/drivers/net/ucc_geth_mii.c
> +++ b/drivers/net/ucc_geth_mii.c
> @@ -217,6 +217,9 @@ static int uec_mdio_probe(struct of_device  
> *ofdev, const struct of_device_id *ma
>  		}
>  	}
>
> +	/* register ourselves as the owner of this bus */
> +	new_bus->owner = THIS_MODULE;
> +
>  	err = mdiobus_register(new_bus);
>  	if (0 != err) {
>  		printk(KERN_ERR "%s: Cannot register as MDIO bus\n",


Any reason you didn't update the other drivers?

 > git grep mdiobus_register drivers/net/          // duplicates and  
mdio_bus.c edited out
drivers/net/au1000_eth.c:       mdiobus_register(&aup->mii_bus);
drivers/net/bfin_mac.c: mdiobus_register(&lp->mii_bus);
drivers/net/cpmac.c:    res = mdiobus_register(&cpmac_mii);
drivers/net/fec_mpc52xx_phy.c:  err = mdiobus_register(bus);
drivers/net/fs_enet/mii-bitbang.c:      ret = mdiobus_register(new_bus);
drivers/net/fs_enet/mii-fec.c:  ret = mdiobus_register(new_bus);
drivers/net/gianfar_mii.c:      err = mdiobus_register(new_bus);
drivers/net/macb.c:     if (mdiobus_register(&bp->mii_bus))
drivers/net/sb1250-mac.c:       err = mdiobus_register(&sc->mii_bus);
drivers/net/ucc_geth_mii.c:     err = mdiobus_register(new_bus);

I'm guessing this was only tested on the UEC, because unless I  
misunderstand the code, any other driver would now crash when you try  
to get the owner.

Andy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html