netdev - Re: Not understand some in htb_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080115.210729.128392129.davem@davemloft.net>
Date:	Tue, 15 Jan 2008 21:07:29 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	kaber@...sh.net
Cc:	devik@....cz, slavon@...telecom.ru, netdev@...r.kernel.org
Subject: Re: Not understand some in htb_do_events function

From: Patrick McHardy <kaber@...sh.net>
Date: Tue, 15 Jan 2008 16:54:41 +0100

> Martin Devera wrote:
> > to drain extra events asap. It the time of writing I was not able to
> > come with better solution and there were more bugs related to this
> > part of code than now.
> 
> So this was meant to protect against endless loops?

I think, as Martin tried to explain further, it's trying
to avoid cases where the amount of work is extremely large.

Heuristics like this are by definition going to hit cases
where the value chosen is wrong or inappropriate.  On fast
cpus maybe a value of 50000 instead of 500 would work "best"

Therefore I would suggest removing the limit altogether for now and in
the long term work on whatever deficiencies in the algorithm make this
expensive enough to warrant limits in the first place.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html