netdev - Re: [PATCH net-2.6.25 4/7][ATM]: [br2864] routed support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f696b20801152016r52048016g7c293dbfdc6c9f29@mail.gmail.com>
Date:	Wed, 16 Jan 2008 12:16:46 +0800
From:	"Chung-Chi Lo" <linolo@...il.com>
To:	"chas williams - CONTRACTOR" <chas@....nrl.navy.mil>
Cc:	netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH net-2.6.25 4/7][ATM]: [br2864] routed support

On Dec 30, 2007 9:07 AM, chas williams - CONTRACTOR
<chas@....nrl.navy.mil> wrote:
> commit fea6b121bcc150fc91186e5012466c91944ce64d
> Author: Eric Kinzie <ekinzie@....nrl.navy.mil>
> Date:   Fri Oct 26 08:05:08 2007 -0400
>
>     [ATM]: [br2864] routed support
>
>     From: Eric Kinzie <ekinzie@....nrl.navy.mil>
>     Signed-off-by: Chas Williams <chas@....nrl.navy.mil>
>
> @@ -320,35 +361,50 @@ static void br2684_push(struct atm_vcc *atmvcc, struct sk_buff *skb)
>         } else {
>                 /* first 2 chars should be 0 */
>                 if (*((u16 *) (skb->data)) != 0) {
>                         brdev->stats.rx_errors++;
>                         dev_kfree_skb(skb);
>                         return;
>                 }
> +               skb_pull(skb, BR2684_PAD_LEN + ETH_HLEN); /* pad, dstmac, srcmac, ethtype */
> +               skb->protocol = eth_type_trans(skb, net_dev);
>         }

Question to decode the encaps=VCMUX and bridge mode:

This line

skb_pull((skb, BR2684_PAD_LEN + ETH_HLEN);

should be replaced by

skb_pull((skb, BR2684_PAD_LEN);

?

By the way, this routed mode patch doesn't include encaps=VCMUX and
RFC2684 routed
protocol decapsulation?

-- 
Lino, Chung-Chi Lo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html