netdev - Re: [PATCH] ICMP: ICMP_MIB_OUTMSGS increment duplicated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1JFHVh-00012A-00@gondolin.me.apana.org.au>
Date:	Thu, 17 Jan 2008 10:17:29 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	dlstevens@...ibm.com (David Stevens)
Cc:	herbert@...dor.apana.org.au, davem@...emloft.net,
	netdev@...r.kernel.org, wangchen@...fujitsu.com
Subject: Re: [PATCH] ICMP: ICMP_MIB_OUTMSGS increment duplicated

David Stevens <dlstevens@...ibm.com> wrote:
>
>        The patch was to support the ICMPMsgStats table. Since none of 
> certain
> types of output ICMP messages are generated by the kernel, but are 
> required
> by the RFC, counting raw sockets is intentional (and the only way those 
> ICMP
> types can be counted at all).
>        Raw UDP packets would not be counted either before or after the 
> patch,
> but aren't part of the ICMPMsgStats table. Adding those might be 
> worthwhile,
> but it isn't quite the hole that the ICMP out stats were, since there is a
> cooked interface for UDP output that counts the common use, at least.

Fair enough.  How about moving this code back into icmp.c and just
add a new count call in raw.c? The push pending function is used on
the UDP fast path so the leaner it is the better.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html