netdev - Re: [patch] add net_device_stats support to ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200801170513.m0H5DNaQ004767@sallyv1.ics.uci.edu>
Date:	Wed, 16 Jan 2008 21:13:19 -0800
From:	Dan Nicolaescu <dann@....uci.edu>
To:	Ben Greear <greearb@...delatech.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [patch] add net_device_stats support to ethtool

Ben Greear <greearb@...delatech.com> writes:

  > Dan Nicolaescu wrote:
  > > Ben Greear <greearb@...delatech.com> writes:
  > >
  > >   > Dan Nicolaescu wrote:
  > >   > > Hi,
  > >   > >
  > >   > > I have posted this patch in the past with absolutely no reply.
  > >   > > I would appreciate some sort of feedback of the form interested/not
  > >   > > interested.  Should I just drop it?
  > >   > >
  > >   > >     > I like it, but why not offer this for all devices since
  > > they all have
  > >   > these stats.
  > >   >
  > >   > Could add new handlers called something like .get_strings_generic, or
  > >   > just add this to the higher-level ethtool handling before it looks for
  > >   > handlers.
  > >
  > > If I get your point, then the difference would be that drivers would add
  > > to the initialization of the ethtool structure something like:
  > >   
  > I meant something more like this (this will not apply..I hand-edited
  > it to remove
  > some extraneous crap from my patch...and I'm sure it's white-space damaged).

OK.
Hopefully someone can pick up these patches to be merged...
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html