netdev - Re: [FIB]: Fix rcu_dereference() abuses in fib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080118.033153.235763392.davem@davemloft.net>
Date:	Fri, 18 Jan 2008 03:31:53 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dada1@...mosbay.com
Cc:	netdev@...r.kernel.org, stephen.hemminger@...tta.com,
	herbert@...dor.apana.org.au
Subject: Re: [FIB]: Fix rcu_dereference() abuses in fib_trie.c

From: Eric Dumazet <dada1@...mosbay.com>
Date: Tue, 15 Jan 2008 09:29:40 +0100

> node_parent() and tnode_get_child() currently use rcu_dereference().
> 
> These functions are called from both 
> - readers only paths (where rcu_dereference() is needed), and 
> - writer path (where rcu_dereference() is not needed)
> 
> To make explicit where rcu_dereference() is really needed, I introduced
> new node_parent_rcu() and tnode_get_child_rcu() functions which use
> rcu_dereference(), while node_parent() and tnode_get_child() dont use it.
> 
> Then I changed calling sites where rcu_dereference() was really needed to
> call the _rcu() variants.
> 
> This should have no impact but for alpha architecture, and may help future
> sparse checks.
> 
> Signed-off-by: Eric Dumazet <dada1@...mosbay.com>

Applied to net-2.6.25, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html