netdev - Re: [patch v3] Documentation: add a guideline for hard_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47910115.2030102@pobox.com>
Date:	Fri, 18 Jan 2008 14:42:13 -0500
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Matti Linnanvuori <mattilinnanvuori@...oo.com>
CC:	netdev@...r.kernel.org
Subject: Re: [patch v3] Documentation: add a guideline for hard_start_xmit
 method

Matti Linnanvuori wrote:
> From: Matti Linnanvuori <mattilinnanvuori@...oo.com>
> 
> Add a guideline not to modify SKBs.
> 
> Signed-off-by: Matti Linnanvuori <mattilinnanvuori@...oo.com>
> 
> ---
> 
> --- a/Documentation/networking/driver.txt 2008-01-13 07:14:01.608291500 +0200
> +++ b/Documentation/networking/driver.txt 2008-01-15 16:16:14.636054000 +0200
> @@ -61,7 +61,10 @@ Transmit path guidelines:
>  2) Do not forget to update netdev->trans_start to jiffies after
>     each new tx packet is given to the hardware.
>  
> -3) Do not forget that once you return 0 from your hard_start_xmit
> +3) A hard_start_xmit method must not modify the shared parts of a
> +   cloned SKB.
> +
> +4) Do not forget that once you return 0 from your hard_start_xmit
>     method, it is your driver's responsibility to free up the SKB
>     and in some finite amount of time.

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html