netdev - Re: [PATCH] SGISEEQ: fix oops when doing ifconfig down; ifconfig up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <479105AD.6060201@garzik.org>
Date:	Fri, 18 Jan 2008 15:01:49 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Thomas Bogendoerfer <tsbogend@...ha.franken.de>
CC:	netdev@...r.kernel.org, linux-mips@...ux-mips.org,
	ralf@...ux-mips.org, jgarzik@...ox.com
Subject: Re: [PATCH] SGISEEQ: fix oops when doing ifconfig down; ifconfig
 up

Thomas Bogendoerfer wrote:
> When doing init_ring checking whether a new skb needs to be allocated
> was wrong.
> 
> Signed-off-by: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
> ---
> 
> This is a bug fix for the 2.6.25 driver.
> 
>  drivers/net/sgiseeq.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/sgiseeq.c b/drivers/net/sgiseeq.c
> index c69bb8b..78994ed 100644
> --- a/drivers/net/sgiseeq.c
> +++ b/drivers/net/sgiseeq.c
> @@ -193,7 +193,7 @@ static int seeq_init_ring(struct net_device *dev)
>  
>  	/* And now the rx ring. */
>  	for (i = 0; i < SEEQ_RX_BUFFERS; i++) {
> -		if (!sp->rx_desc[i].rdma.pbuf) {
> +		if (!sp->rx_desc[i].skb) {
>  			dma_addr_t dma_addr;
>  			struct sk_buff *skb = netdev_alloc_skb(dev, PKT_BUF_SZ);

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html