netdev - Re: [patch] add net_device_stats support to ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200801182201.m0IM16pw015740@sallyv1.ics.uci.edu>
Date:	Fri, 18 Jan 2008 14:01:06 -0800
From:	Dan Nicolaescu <dann@....uci.edu>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	netdev@...r.kernel.org
Subject: Re: [patch] add net_device_stats support to ethtool

Jeff Garzik <jeff@...zik.org> writes:

  > Dan Nicolaescu wrote:
  > > Hi,
  > >
  > > I have posted this patch in the past with absolutely no reply.
  > > I would appreciate some sort of feedback of the form interested/not
  > > interested.  Should I just drop it?
  > >
  > > "ethtool -S" only supports devices that have custom code written to
  > > print the stats. 
  > 
  > No -- more specifically, ethtool is for NIC-specific statistics that
  > do not appear elsewhere.
  > 
  > net_device_stats already appear elsewhere, so it's redundant to add it
  > to ethtool.  Just duplicates the same functionality elsewhere.

Then please add to -S entry of the ethtool man page something like:
"Only statistics for devices that do not use the generic stat
infrastructure are printed".
It is rather confusing for users that "ethtool -S" prints stats for some
devices, and nothing for others, and the documentations says nothing
about this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html