netdev - Re: [2.6 patch] atm/suni.c: fix section mismatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080119132904.GC26615@uranus.ravnborg.org>
Date:	Sat, 19 Jan 2008 14:29:04 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	chas@....nrl.navy.mil, jgarzik@...ox.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] atm/suni.c: fix section mismatch

On Sat, Jan 19, 2008 at 03:18:51PM +0200, Adrian Bunk wrote:
> EXPORT_SYMBOL'ed code mustn't be __*init.
> 
> Signed-off-by: Adrian Bunk <bunk@...nel.org>
Acked-by: Sam Ravnborg <sam@...nborg.org>
> 
> ---
> --- linux-2.6/drivers/atm/suni.c.old	2008-01-19 12:16:41.000000000 +0200
> +++ linux-2.6/drivers/atm/suni.c	2008-01-19 12:17:23.000000000 +0200
> @@ -275,35 +275,35 @@ static int suni_stop(struct atm_dev *dev
>  	*walk = PRIV((*walk)->dev)->next;
>  	if (!sunis) del_timer_sync(&poll_timer);
>  	spin_unlock_irqrestore(&sunis_lock,flags);
>  	kfree(PRIV(dev));
>  
>  	return 0;
>  }
>  
>  
>  static const struct atmphy_ops suni_ops = {
>  	.start		= suni_start,
>  	.ioctl		= suni_ioctl,
>  	.interrupt	= suni_int,
>  	.stop		= suni_stop,
>  };
>  
>  
> -int __devinit suni_init(struct atm_dev *dev)
> +int suni_init(struct atm_dev *dev)
>  {
>  	unsigned char mri;
>  
>  	mri = GET(MRI); /* reset SUNI */
>  	PUT(mri | SUNI_MRI_RESET,MRI);
>  	PUT(mri,MRI);
>  	PUT((GET(MT) & SUNI_MT_DS27_53),MT); /* disable all tests */
>  	REG_CHANGE(SUNI_TPOP_APM_S,SUNI_TPOP_APM_S_SHIFT,SUNI_TPOP_S_SONET,
>  	    TPOP_APM); /* use SONET */
>  	REG_CHANGE(SUNI_TACP_IUCHP_CLP,0,SUNI_TACP_IUCHP_CLP,
>  	    TACP_IUCHP); /* idle cells */
>  	PUT(SUNI_IDLE_PATTERN,TACP_IUCPOP);
>  	dev->phy = &suni_ops;
>  	return 0;
>  }
>  
>  EXPORT_SYMBOL(suni_init);
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html