netdev - Re: [PATCH] net: add sparse annotation to ptype_seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080121050355.GD7541@linux.vnet.ibm.com>
Date:	Sun, 20 Jan 2008 21:03:55 -0800
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	josh@...edesktop.org
Subject: Re: [PATCH] net: add sparse annotation to ptype_seq_start/stop

On Sun, Jan 20, 2008 at 03:21:46PM -0800, Stephen Hemminger wrote:
> Get rid of some more sparse warnings.
> 
> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>

Adding Josh to CC -- is __acquires() case-insensitive?  If not, this
needs to be __acquires(RCU) and __releases(RCU).

						Thanx, Paul

> --- a/net/core/dev.c	2008-01-20 14:25:00.000000000 -0800
> +++ b/net/core/dev.c	2008-01-20 14:25:48.000000000 -0800
> @@ -2543,6 +2543,7 @@ static void *ptype_get_idx(loff_t pos)
>  }
> 
>  static void *ptype_seq_start(struct seq_file *seq, loff_t *pos)
> +	__acquires(rcu)
>  {
>  	rcu_read_lock();
>  	return *pos ? ptype_get_idx(*pos - 1) : SEQ_START_TOKEN;
> @@ -2578,6 +2579,7 @@ found:
>  }
> 
>  static void ptype_seq_stop(struct seq_file *seq, void *v)
> +	__releases(rcu)
>  {
>  	rcu_read_unlock();
>  }
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html