netdev - Re: [PATCH 2/4] dsmark: get rid of trivial function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4793E460.5020804@trash.net>
Date:	Mon, 21 Jan 2008 01:16:32 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	Stephen Hemminger <shemminger@...tta.com>
CC:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH 2/4] dsmark: get rid of trivial function

Stephen Hemminger wrote:
> Replace loop in dsmark_valid_indices with equivalent bit math.
> 
> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
> 
> --- a/net/sched/sch_dsmark.c	2008-01-20 13:07:58.000000000 -0800
> +++ b/net/sched/sch_dsmark.c	2008-01-20 13:22:54.000000000 -0800
> @@ -45,13 +45,8 @@ struct dsmark_qdisc_data {
>  
>  static inline int dsmark_valid_indices(u16 indices)
>  {
> -	while (indices != 1) {
> -		if (indices & 1)
> -			return 0;
> -		indices >>= 1;
> -	}
> -
> -	return 1;
> +	/* Must have only one bit set */
> +	return (indices & (indices - 1)) == 0;


hweight seems easier to understand, it took me a bit
to realize that the comment matches the code :)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html