netdev - Re: [PATCH 1/3][NET] gen_estimator: faster gen_kill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080121.023515.256390630.davem@davemloft.net>
Date:	Mon, 21 Jan 2008 02:35:15 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jarkao2@...il.com
Cc:	netdev@...r.kernel.org, slavon@...telecom.ru, kaber@...sh.net,
	hadi@...erus.ca
Subject: Re: [PATCH 1/3][NET] gen_estimator: faster gen_kill_estimator

From: Jarek Poplawski <jarkao2@...il.com>
Date: Mon, 21 Jan 2008 00:46:59 +0100

I like the technique you used to fix this bug, but:

> diff -Nurp 2.6.24-rc8-mm1-/include/linux/gen_stats.h 2.6.24-rc8-mm1+/include/linux/gen_stats.h
> --- 2.6.24-rc8-mm1-/include/linux/gen_stats.h	2007-10-09 22:31:38.000000000 +0200
> +++ 2.6.24-rc8-mm1+/include/linux/gen_stats.h	2008-01-20 20:37:08.000000000 +0100
> @@ -28,11 +28,13 @@ struct gnet_stats_basic
>   * struct gnet_stats_rate_est - rate estimator
>   * @bps: current byte rate
>   * @pps: current packet rate
> + * @gen_estimator: internal data
>   */
>  struct gnet_stats_rate_est
>  {
>  	__u32	bps;
>  	__u32	pps;
> +	unsigned long	gen_estimator;
>  };
>  
>  /**

Sorry, this structure is exported to userspace so we can't
change it like that.

It is an attribute passed over netlink sockets.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html