netdev - Re: [PATCH 3/5] netns netfilter: return new table from {arp,ip,ip6}t_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4796206C.4060100@trash.net>
Date:	Tue, 22 Jan 2008 17:57:16 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	Alexey Dobriyan <adobriyan@...ru>
CC:	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org,
	devel@...nvz.org
Subject: Re: [PATCH 3/5] netns netfilter: return new table from {arp,ip,ip6}t_register_table()

Alexey Dobriyan wrote:
> Typical table module registers xt_table structure (i.e. packet_filter)
> and link it to list during it. We can't use one template for it because
> corresponding list_head will become corrupted. We also can't unregister
> with template because it wasn't changed at all and thus doesn't know in
> which list it is.
> 
> So, we duplicate template at the very first step of table registration.
> Table modules will save it for use during unregistration time and actual
> filtering.
> 
> Do it at once to not screw bisection.

Applied, thanks.

> P.S.: renaming i.e. packet_filter => __packet_filter is temporary until
>       full netnsization of table modules is done.

It seems this could have been avoided by ordering the patches
differently (I probably would also have done 4/5 as 1/5).
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html