netdev - [Bug 9750] dev: avoid a race that triggers assertion failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <265315.88937.qm@web52009.mail.re2.yahoo.com>
Date:	Tue, 22 Jan 2008 03:27:00 -0800 (PST)
From:	Matti Linnanvuori <mattilinnanvuori@...oo.com>
To:	netdev@...r.kernel.org, jgarzik@...ox.com
Cc:	bugme-daemon@...nel-bugs.osdl.org
Subject: [Bug 9750] dev: avoid a race that triggers assertion failure

From: Matti Linnanvuori <mattilinnanvuori@...oo.com>

There is a race in Linux kernel file net/core/dev.c, function dev_close.
The function calls function dev_deactivate, which calls function
dev_watchdog_down that deletes the watchdog timer. However, after that, a
driver can call netif_carrier_ok, which calls function
__netdev_watchdog_up that can add the watchdog timer again. Function
unregister_netdevice calls function dev_shutdown that traps the bug
!timer_pending(&dev->watchdog_timer).

Signed-off-by: Matti Linnanvuori <mattilinnanvuori@...oo.com>

---

--- linux-2.6.23.8/net/core/dev.c    2007-11-16 20:14:27.000000000 +0200
+++ linux-2.6.23.15/net/core/dev.c    2008-01-22 13:16:12.347125794 +0200
@@ -1013,8 +1013,6 @@ int dev_close(struct net_device *dev)
      */
     raw_notifier_call_chain(&netdev_chain, NETDEV_GOING_DOWN, dev);
 
-    dev_deactivate(dev);
-
     clear_bit(__LINK_STATE_START, &dev->state);
 
     /* Synchronize to scheduled poll. We cannot touch poll list,
@@ -1029,6 +1027,8 @@ int dev_close(struct net_device *dev)
         msleep(1);
     }
 
+    dev_deactivate(dev);
+
     /*
      *    Call the device specific close. This cannot fail.
      *    Only if device is UP





      ____________________________________________________________________________________
Looking for last minute shopping deals?  
Find them fast with Yahoo! Search.  http://tools.search.yahoo.com/newsearch/category.php?category=shopping
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html