netdev - Re: [PATCH 2.6.25 1/1]S2io: Multiqueue network device support implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4796906F.2010503@garzik.org>
Date:	Tue, 22 Jan 2008 19:55:11 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Sreenivasa Honnur <Sreenivasa.Honnur@...erion.com>
CC:	netdev@...r.kernel.org, support@...erion.com
Subject: Re: [PATCH 2.6.25 1/1]S2io: Multiqueue network device support implementation

Sreenivasa Honnur wrote:
> Multiqueue netwrok device support implementation.
> - Added a loadable parameter "multiq" to enable/disable multiqueue support,
>   by default it is disabled.
> - skb->queue_mapping is not used for queue/fifo selection. FIFO iselection is
>   based on IP-TOS value, 0x0-0xF TOS values are mapped to 8 FIFOs.
> - Added per FIFO flags FIFO_QUEUE_START and FIFO_QUEUE_STOP. Check this flag
>   for starting and stopping netif queue and update the flags accordingly.
> - In tx_intr_handler added a check to ensure that we have free TXDs before wak-
>   ing up the queue.
> - Added helper functions for queue manipulation(start/stop/wakeup) to invoke
>   appropriate netif_ functions.
> - Calling netif_start/stop for link up/down case respectively.
> 
> Signed-off-by: Surjit Reang <surjit.reang@...erion.com>
> Signed-off-by: Sreenivasa Honnur <sreenivasa.honnur@...erion.com>

thanks, at a quick glance, the use of the new multi-queue APIs look ok. 
  I'll give it another in-depth look and merge it.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html