netdev - Re: [INET]: Fix truesize setting in ip_append

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080122.214719.168781298.davem@davemloft.net>
Date:	Tue, 22 Jan 2008 21:47:19 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	netdev@...r.kernel.org
Subject: Re: [INET]: Fix truesize setting in ip_append_data

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Wed, 23 Jan 2008 14:39:42 +1100

> [INET]: Fix truesize setting in ip_append_data
> 
> As it is ip_append_data only counts page fragments to the skb that
> allocated it.  As such it means that the first skb gets hit with a
> 4K charge even though it might have only used a fraction of it while
> all subsequent skb's that use the same page gets away with no charge
> at all.
> 
> This bug was exposed by the UDP accounting patch.
> 
> This patch also fixes a similar bug in ip_append_page spotted by you :)
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

I added this to net-2.6, thanks Herbert!

I already checked in the ip_append_page() fix to net-2.6 so
I simply removed that hunk when adding your fix.

Thanks again!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html