netdev - [Bug 9750] [patch 2.6.24] dev: avoid a race that triggers assertion failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 22 Jan 2008 22:34:05 -0800 (PST)
From:	Matti Linnanvuori <mattilinnanvuori@...oo.com>
To:	netdev@...r.kernel.org, jgarzik@...ox.com
Cc:	bugme-daemon@...nel-bugs.osdl.org
Subject: [Bug 9750] [patch 2.6.24] dev: avoid a race that triggers assertion failure

From: Matti Linnanvuori <mattilinnanvuori@...oo.com>

There is a race in Linux kernel file net/core/dev.c, function dev_close.
The function calls function dev_deactivate, which calls function
dev_watchdog_down that deletes the watchdog timer. However, after that, a
driver can call netif_carrier_ok, which calls function
__netdev_watchdog_up that can add the watchdog timer again. Function
unregister_netdevice calls function dev_shutdown that traps the bug
!timer_pending(&dev->watchdog_timer). Moving dev_deactivate after
netif_running() has been cleared prevents function netif_carrier_on
from calling __netdev_watchdog_up and adding the watchdog timer again.

Signed-off-by: Matti Linnanvuori <mattilinnanvuori@...oo.com>

---

--- linux-2.6.24/net/core/dev.c    2008-01-23 08:20:55.733012300 +0200
+++ b/net/core/dev.c    2008-01-23 08:24:32.818766600 +0200
@@ -1068,8 +1068,6 @@ int dev_close(struct net_device *dev)
      */
     call_netdevice_notifiers(NETDEV_GOING_DOWN, dev);

-    dev_deactivate(dev);
-
     clear_bit(__LINK_STATE_START, &dev->state);

     /* Synchronize to scheduled poll. We cannot touch poll list,
@@ -1080,6 +1078,8 @@ int dev_close(struct net_device *dev)
      */
     smp_mb__after_clear_bit(); /* Commit netif_running(). */

+    dev_deactivate(dev);
+
     /*
      *    Call the device specific close. This cannot fail.
      *    Only if device is UP

      ____________________________________________________________________________________
Never miss a thing.  Make Yahoo your home page. 
http://www.yahoo.com/r/hs
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html