netdev - Re: [Cbe-oss-dev] [PATCH 1/5] spidernet: add missing initialization

Open Source and information security mailing list archives

Date:	Wed, 23 Jan 2008 14:53:42 +0100
From:	Jens Osterkamp <jens@...ibm.com>
To:	cbe-oss-dev@...abs.org
Cc:	Ishizaki Kou <kou.ishizaki@...hiba.co.jp>, netdev@...r.kernel.org
Subject: Re: [Cbe-oss-dev] [PATCH 1/5] spidernet: add missing initialization

On Friday 11 January 2008, Ishizaki Kou wrote:
> This patch fixes initialization of "aneg_count" and "medium" fields in
> spider_net_card to make spidernet driver correctly sets "link status".
> 
> Signed-off-by: Kou Ishizaki <kou.ishizaki@...hiba.co.jp>

Acked-by: Jens Osterkamp <jens@...ibm.com>

> ---
> 
> Index: linux-powerpc-git/drivers/net/spider_net.c
> ===================================================================
> --- linux-powerpc-git.orig/drivers/net/spider_net.c
> +++ linux-powerpc-git/drivers/net/spider_net.c
> @@ -1399,6 +1399,8 @@ spider_net_link_reset(struct net_device 
>  	spider_net_write_reg(card, SPIDER_NET_GMACINTEN, 0);
> 
>  	/* reset phy and setup aneg */
> +	card->aneg_count = 0;
> +	card->medium = BCM54XX_COPPER;
>  	spider_net_setup_aneg(card);
>  	mod_timer(&card->aneg_timer, jiffies + SPIDER_NET_ANEG_TIMER);
> 
> @@ -1982,6 +1984,8 @@ spider_net_open(struct net_device *netde
>  		goto init_firmware_failed;
> 
>  	/* start probing with copper */
> +	card->aneg_count = 0;
> +	card->medium = BCM54XX_COPPER;
>  	spider_net_setup_aneg(card);
>  	if (card->phy.def->phy_id)
>  		mod_timer(&card->aneg_timer, jiffies + SPIDER_NET_ANEG_TIMER);
> _______________________________________________
> cbe-oss-dev mailing list
> cbe-oss-dev@...abs.org
> https://ozlabs.org/mailman/listinfo/cbe-oss-dev
>
-- 

Gruß,

Jens

IBM Deutschland Entwicklung GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Herbert Kircher 
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives