lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 24 Jan 2008 14:06:22 +0900 From: "Joonwoo Park" <joonwpark81@...il.com> To: "Eric Dumazet" <dada1@...mosbay.com> Cc: "David Miller" <davem@...emloft.net>, netdev@...r.kernel.org Subject: Re: [PATCH] [IPV4] route: fix locking in rt_run_flush() 2008/1/24, Eric Dumazet <dada1@...mosbay.com>: > > Unfortunatly, your patch doesnt work on CONFIG_SMP=n (softirq will be disabled > for the whole scan of table) > > Also, some machines around there have 2^22 slots in hash table, and NR_CPUS=4, > so softirqs will be disabled for a too long time. > > Please try net-2.6.25 and submit patches on top of it if necessary, since > rt_run_flush() has pending changes, not in net-2.6 > > Note : The 'soft lockup' can be avoided by other means. > > Eric, Thank you for your help. I checked net-2.6.25 in this morining :( And it brought me a conclusion that the fashion of it is the best solution for the all circumstances. I believe that 'cond_resched()' and 'if (!rth) continue' without disable softirq of net-2.6.25 is correct answer. Thanks again! Joonwoo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists