[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080125150257.578a108f@deepthought>
Date: Fri, 25 Jan 2008 15:02:57 -0800
From: Stephen Hemminger <shemminger@...ux-foundation.org>
To: "Alon Bar-Lev" <alon.barlev@...il.com>
Cc: netdev@...r.kernel.org
Subject: Re: iproute2 (addr flush) infinite loop when unprivileged users
On Sat, 26 Jan 2008 01:00:34 +0200
"Alon Bar-Lev" <alon.barlev@...il.com> wrote:
> Hello,
>
> When executing the following command using unprivileged users there is
> an infinite loop...
> /sbin/ip route flush dev eth1
>
> Execution with -s produces:
> *** Round 28153, deleting 2 entries ***
>
> *** Round 28154, deleting 2 entries ***
>
> *** Round 28155, deleting 2 entries ***
>
> *** Round 28156, deleting 2 entries ***
>
> *** Round 28157, deleting 2 entries ***
>
> *** Round 28158, deleting 2 entries ***
>
> *** Round 28159, deleting 2 entries ***
>
> I do not fully understand the sequence, but it may be kernel fault, as
> it should have returned EPERM for this request stopping the netlink
> request.
>
> Anyway... A simple solution is to store the filter.flushed and fail if
> it keeps its value during loop iteration at
> ip/ipaddress.c::ipaddr_list_or_flush(), but this is only a
> workaround...
>
> Please CC as I am not in netdev list.
> Thanks!
> Alon.
Non privileged users can't delete routes, but command keeps trying.
The correct way to handle it is to teach flush loop to look at error code.
--
Stephen Hemminger <stephen.hemminger@...tta.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists