netdev - RE: [PATCH 2.6.25 1/1]S2io: Multiqueue network device support implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <78C9135A3D2ECE4B8162EBDCE82CAD7702E713B2@nekter>
Date:	Thu, 24 Jan 2008 22:19:50 -0500
From:	"Ramkrishna Vepa" <Ramkrishna.Vepa@...erion.com>
To:	"David Miller" <davem@...emloft.net>, <andi@...stfloor.org>
Cc:	"Sreenivasa Honnur" <Sreenivasa.Honnur@...erion.com>,
	<netdev@...r.kernel.org>, <jeff@...zik.org>,
	"support" <support@...erion.com>
Subject: RE: [PATCH 2.6.25 1/1]S2io: Multiqueue network device support implementation

> From: netdev-owner@...r.kernel.org
[mailto:netdev-owner@...r.kernel.org]
> On Behalf Of David Miller
> Sent: Wednesday, January 23, 2008 11:30 PM
> 
> From: Andi Kleen <andi@...stfloor.org>
> Date: Thu, 24 Jan 2008 08:25:49 +0100
> 
> > > have done away with handling tx completion in the interrupt
handler,
> and
> > > are instead handling them in the context of the transmit. The slow
> path,
> > > straggling transmit completions will be handled in the timer
context.
> >
> > Ok -- hopefully you don't have bad corner cases from this when the
pipe
> > is not fully filled and then causing longer latencies on completion.
> > Old NAPI sometimes suffered from such problems.
> 
> BTW, such a TX completion timer will stall TCP sockets when the TX
> queue of the device is partially filled and then sending stops.
> 
> TX ring SKB liberation really must be done in a very small finite
> amount of time in order to avoid this problem properly.
> 
> Deferring it to HZ granular timers doesn't give a quick enough
> response, especially at high packet rates.
[Ram] We could add a lower granular tx completion interrupt instead, to
handle all the transmit fifos. But this will be a fall back in the event
the completions do not happen in the context of the transmit.

Ram
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html